drygdryg/calc
1
0
Fork 0
mirror of https://github.com/lcn2/calc.git synced 2025-08-16 01:03:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant assignments when byteswapping.

Browse Source 
The SWAP_ macros already write the result to their destination arg, so
there's no need for an extra assignment -- and this is undefined
behaviour because there are two assignments to the same variable without
an intervening sequence point (as GCC 10 correctly warns).
This commit is contained in:
Adam Sampson
2021-03-06 01:43:54 +00:00
parent 0aca07d278
commit 6dc62c1ab7
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
byteswap.c
View File

@@ -123,8 +123,8 @@ swap_b8_in_ZVALUE(ZVALUE *dest, ZVALUE *src, BOOL all)
* swap or copy the rest of the ZVALUE elements * swap or copy the rest of the ZVALUE elements
*/ */
if (all) { if (all) {
dest->len = (LEN)SWAP_B8_IN_LEN(&dest->len, &src->len); SWAP_B8_IN_LEN(&dest->len, &src->len);
dest->sign = (BOOL)SWAP_B8_IN_BOOL(&dest->sign, &src->sign); SWAP_B8_IN_BOOL(&dest->sign, &src->sign);
} else { } else {
dest->len = src->len; dest->len = src->len;
dest->sign = src->sign; dest->sign = src->sign;
@@ -189,7 +189,7 @@ swap_b8_in_NUMBER(NUMBER *dest, NUMBER *src, BOOL all)
* swap or copy the rest of the NUMBER elements * swap or copy the rest of the NUMBER elements
*/ */
if (all) { if (all) {
dest->links = (long)SWAP_B8_IN_LONG(&dest->links, &src->links); SWAP_B8_IN_LONG(&dest->links, &src->links);
} else { } else {
dest->links = src->links; dest->links = src->links;
} }
@@ -253,7 +253,7 @@ swap_b8_in_COMPLEX(COMPLEX *dest, COMPLEX *src, BOOL all)
* swap or copy the rest of the NUMBER elements * swap or copy the rest of the NUMBER elements
*/ */
if (all) { if (all) {
dest->links = (long)SWAP_B8_IN_LONG(&dest->links, &src->links); SWAP_B8_IN_LONG(&dest->links, &src->links);
} else { } else {
dest->links = src->links; dest->links = src->links;
} }
@@ -358,8 +358,8 @@ swap_b16_in_ZVALUE(ZVALUE *dest, ZVALUE *src, BOOL all)
* swap or copy the rest of the ZVALUE elements * swap or copy the rest of the ZVALUE elements
*/ */
if (all) { if (all) {
dest->len = (LEN)SWAP_B16_IN_LEN(&dest->len, &src->len); SWAP_B16_IN_LEN(&dest->len, &src->len);
dest->sign = (BOOL)SWAP_B16_IN_BOOL(&dest->sign, &src->sign); SWAP_B16_IN_BOOL(&dest->sign, &src->sign);
} else { } else {
dest->len = src->len; dest->len = src->len;
dest->sign = src->sign; dest->sign = src->sign;
@@ -424,7 +424,7 @@ swap_b16_in_NUMBER(NUMBER *dest, NUMBER *src, BOOL all)
* swap or copy the rest of the NUMBER elements * swap or copy the rest of the NUMBER elements
*/ */
if (all) { if (all) {
dest->links = (long)SWAP_B16_IN_LONG(&dest->links, &src->links); SWAP_B16_IN_LONG(&dest->links, &src->links);
} else { } else {
dest->links = src->links; dest->links = src->links;
} }
@@ -488,7 +488,7 @@ swap_b16_in_COMPLEX(COMPLEX *dest, COMPLEX *src, BOOL all)
* swap or copy the rest of the NUMBER elements * swap or copy the rest of the NUMBER elements
*/ */
if (all) { if (all) {
dest->links = (long)SWAP_B16_IN_LONG(&dest->links, &src->links); SWAP_B16_IN_LONG(&dest->links, &src->links);
} else { } else {
dest->links = src->links; dest->links = src->links;
} }
@@ -554,8 +554,8 @@ swap_HALF_in_ZVALUE(ZVALUE *dest, ZVALUE *src, BOOL all)
* swap or copy the rest of the ZVALUE elements * swap or copy the rest of the ZVALUE elements
*/ */
if (all) { if (all) {
dest->len = (LEN)SWAP_HALF_IN_LEN(&dest->len, &src->len); SWAP_HALF_IN_LEN(&dest->len, &src->len);
dest->sign = (BOOL)SWAP_HALF_IN_BOOL(&dest->sign, &src->sign); SWAP_HALF_IN_BOOL(&dest->sign, &src->sign);
} else { } else {
dest->len = src->len; dest->len = src->len;
dest->sign = src->sign; dest->sign = src->sign;
@@ -620,7 +620,7 @@ swap_HALF_in_NUMBER(NUMBER *dest, NUMBER *src, BOOL all)
* swap or copy the rest of the NUMBER elements * swap or copy the rest of the NUMBER elements
*/ */
if (all) { if (all) {
dest->links = (long)SWAP_HALF_IN_LONG(&dest->links,&src->links); SWAP_HALF_IN_LONG(&dest->links, &src->links);
} else { } else {
dest->links = src->links; dest->links = src->links;
} }
@@ -684,7 +684,7 @@ swap_HALF_in_COMPLEX(COMPLEX *dest, COMPLEX *src, BOOL all)
* swap or copy the rest of the NUMBER elements * swap or copy the rest of the NUMBER elements
*/ */
if (all) { if (all) {
dest->links = (long)SWAP_HALF_IN_LONG(&dest->links,&src->links); SWAP_HALF_IN_LONG(&dest->links, &src->links);
} else { } else {
dest->links = src->links; dest->links = src->links;
} }